Dear Richard Zhao, [...] > +static int imx6q_usbmisc_init(struct usbmisc *usbmisc, int id) > +{ > + u32 reg; > + > + if (usbmisc->dis_oc) { > + reg = readl_relaxed(usbmisc->base + id * 4); > + writel_relaxed(reg | (1 << 7), usbmisc->base + id * 4); 1<< 7 ? This yearns for fixing with proper #defined value. [...] The rest of the patches looks OK, you can add my Reviewed-By: <marex@xxxxxxx> to those. This one though will need further investigation. Best regards, Marek Vasut _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-arm-kernel