Re: [PATCH 3/3] arm: mach-mvebu: system-controller only registers restart if device exists

[Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>]

On Thu, Jun 28, 2012 at 10:23:21AM +0100, Ben Dooks wrote:
> On 27/06/12 20:19, Russell King - ARM Linux wrote:
>> On Wed, Jun 27, 2012 at 05:26:46PM +0100, Ben Dooks wrote:
>>> Change to only registering the restart hook if the device exists
>>> and can be enumerated in the device tree. Remove the header definiton
>>> and the restart entry in the machine file.
>>
>> NAK.  Please use the .restart method in the machine description rather
>> than directly using arm_pm_restart.  Thanks.
>>
>> arm_pm_restart only continues to exist because I could not work out how
>> to stop AT91 from using it.
>
> So what should you do if your board doesn't support this method of
> resetting?

Eh, what?

Set the .restart method in MACHINE_DESC or DT_MACHINE_DESC.  Try to avoid
using arm_pm_restart directly.

Simples.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel