Re: [PATCH] kprobes: only test 'sub pc, pc, #1b-2b+8-2' on ARMv6

[Rabin Vincent <rabin@xxxxxx>]

On Fri, Jun 15, 2012 at 7:06 PM, Tixy <tixy@xxxxxxxxxx> wrote:
>> How about the following check instead?  At least one other place uses
>> it.
>
> Can't you point out the other place which uses it, I couldn't find it.

arch/arm/kernel/entry-armv.S:445
#if CONFIG_ARM_THUMB && __LINUX_ARM_ARCH__ >= 6 && CONFIG_CPU_V7

> The proposed patch below would work, but feels slightly off as it
> assumes that no one will build a kernel to support V6 and V8, but
> without V7. That does seem highly unlikely though, so I personally
> wouldn't object to the patch.

I've no preference either way, so if a deletion of the test case would get your
acked-by instead of just a non-objection, I'll do that.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel