Re: [PATCH v3 05/12] usb: chipidea: add imx platform driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Richard Zhao <richard.zhao@xxxxxxxxxxxxx> writes:

> On Fri, May 25, 2012 at 11:37:26AM +0300, Alexander Shishkin wrote:
>> Richard Zhao <richard.zhao@xxxxxxxxxxxxx> writes:
>> > This patch supports only the host-mode functionality so far.
>> >
>> > Signed-off-by: Richard Zhao <richard.zhao@xxxxxxxxxxxxx>
>> > Signed-off-by: Marek Vasut <marex@xxxxxxx>
>> > Cc: Peter Chen <peter.chen@xxxxxxxxxxxxx>
>> > Cc: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
>> > Cc: Felipe Balbi <balbi@xxxxxx>
>> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>> > ---
>> >  .../devicetree/bindings/usb/ci13xxx-imx.txt        |   20 ++
>> >  drivers/usb/chipidea/Makefile                      |    3 +
>> >  drivers/usb/chipidea/ci13xxx_imx.c                 |  189 ++++++++++++++++++++
>> One comment: I was going to suggest dropping "13xxx" suffix from
>> everywhere in the driver, maybe module names too, since it doesn't
>> really add any value and people often mistype it, so maybe for the new
>> code it makes sense to avoid it? ci-imx looks better than ci13xxx-imx
>> anyway and same goes for ci_imx_probe() vs ci13xxx_imx_probe().
>> Does this make sense to you?
> I'm not clear with the history. Does Chipidea only have one IP?

As far as their USB controllers go, there are several versions with
different features and register layouts, but essentially similar. I want
to support all of them with this driver. As for the other IPs designed
by chipidea -- I have no idea about those, but I don't think we should


linux-arm-kernel mailing list

[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter