Re: [RFC] pl08x: don't use dma_slave_config direction argument

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Thu, May 17, 2012 at 7:03 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:

> I've just been testing this on the Versatile PB926 with my only working
> peripheral (PL011) and the runtime PM support which was added to the PL08x
> driver is totally breaking this setup.

Ouch! That was a nasty bug.

> So, the only solution I can see is to strip out all the runtime PM stuff
> from PL08x, which is buggy anyway.

I'd just kill it FTM, maybe the patch can simply be reverted?

What worries me is that this is such a straight-forward use of the runtime PM
API, the semantic difficulties with this API has caused me a lot of headache
recently. It just looks simple but isn't.

*_get_sync() should never be called in interrupt context, OK, but this is even
nastier, no calling under any spinlock ... how can we ever guarantee that?

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter