Re: [PATCH v7 3/3] MTD: atmel_nand: Update driver to support Programmable Multibit ECC controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Hi, Artem

On 5/16/2012 5:40 PM, Artem Bityutskiy wrote:
On Wed, 2012-05-16 at 11:31 +0200, Lothar Waßmann wrote:
+		dev_warn(host->dev, "Only 2048 page size is currently " \
+			"supported for PMECC, rolling back to Software ECC\n");
Why do you use backslashes?

message text should not be split across lines anyway to ease grepping
for the message.
I think the consensus is that it is personal decision of the author. I
am not trying to enforce this and I also split messages. In this case I
was only wondering why that backslash is used? I never saw this before
in the linux kernel.

oh, I add the backslash only because if without it, there should be a warning about message is splitting into two lines.

Now I think I will just keep the text message in one line. That will avoid any warnings. thanks.

Best Regards,
Josh Wu

linux-arm-kernel mailing list

[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter