Re: [PATCHv2 04/19] ARM: OMAP4: PM: save/restore all DPLL settings in OFF mode

[Kevin Hilman <khilman@xxxxxx>]

Tero Kristo <t-kristo@xxxxxx> writes:

> From: Rajendra Nayak <rnayak@xxxxxx>
>
> SAR/ROM code restores only CORE DPLL to its original state
> post wakeup from OFF mode.
> The rest of the DPLL's in OMAP4 platform (MPU/IVA/ABE/USB/PER)
> are saved and restored here during an OFF transition.
>
> [nm@xxxxxx: minor cleanups]
> Signed-off-by: Nishanth Menon <nm@xxxxxx>
> Signed-off-by: Rajendra Nayak <rnayak@xxxxxx>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
> Signed-off-by: Tero Kristo <t-kristo@xxxxxx>

Some general comments:

- the register dump/print doesn't belong here.  If needed, should be a
  debug feature if needed.

- Rather than hooking into omap4_enter_lowpower(), should use
  the cluster PM enter/exit notifier chain.

Kevin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel