Re: [PATCH] ARM: OMAP: Cleanup Beagleboard DVI reset gpio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

* Russ Dill <Russ.Dill@xxxxxx> [120509 09:29]:
> On Wed, May 9, 2012 at 8:55 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> > Hi Tomi,
> >
> > * Russ Dill <Russ.Dill@xxxxxx> [120508 19:52]:
> >> This removes several boot warnings from board-omap3beagle.c:
> >>
> >>  - gpio_request: gpio--22 (DVI reset) status -22
> >>  - Unable to get DVI reset GPIO
> >>
> >> There is a combination of leftover code and revision confusion.
> >> Additionally, xM support is currently a hack.
> >>
> >> For original Beagleboard this removes the double initialization of GPIO
> >> 170, properly configures it as an output, and wraps the initialization
> >> in an if block so that xM does not attempt to request it.
> >>
> >> For Beagleboard xM it removes reference to GPIO 129 which was part
> >> of rev A1 and A2 designs, but never functioned. It then properly assigns
> >> beagle_dvi_device.reset_gpio in beagle_twl_gpio_setup and removes the
> >> hack of initializing it high. Additionally, it uses
> >> gpio_set_value_cansleep since this GPIO is connected through i2c.
> >>
> >> Unfortunately, there is no way to tell the difference between xM A2 and
> >> A3. However, GPIO 129 does not function on rev A1 and A2, and the TWL
> >> GPIO used on A3 and beyond is not used on rev A1 and A2, there are no
> >> problems created by this fix.
> >
> > Can you check if this needs updates for your clean up patches?
> 
> I'm not sure what you mean, can you be more specific?

Tomi has a DSS clean-up series posted that affects the board-*.c
files.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter