Re: [PATCHv2] ARM: orion5x: Fix GPIO enable bits for MPP9

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Fri, Apr 20, 2012 at 01:57:00AM +0100, Ben Hutchings wrote:
> On Sun, 2012-04-08 at 05:18 +0100, Ben Hutchings wrote:
> > Commit 554cdaefd1cf7bb54b209c4e68c7cec87ce442a9 ('ARM: orion5x: Refactor
> > mpp code to use common orion platform mpp.') seems to have accidentally
> > inverted the GPIO valid bits for MPP9 (only).  For the mv2120 platform
> > which uses MPP9 as a GPIO LED device, this results in the error:
> > 
> > [   12.711476] leds-gpio: probe of leds-gpio failed with error -22
> > 
> > Reported-by: Henry von Tresckow <hvontres@xxxxxxxxx>
> 
> Tested-by: Hans Henry von Tresckow <hvontres@xxxxxxxxx>

I'm putting this towards fixes for v3.4, adding the above Tested-by:

thx,

Jason.

> 
> (on the mv2120, and applied to Debian's 3.2 tree)
> 
> > References: http://bugs.debian.org/667446
> > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx [v3.0+]
> > ---
> > v2: Add subject of the earlier commit
> > 
> > Ben.
> > 
> >  arch/arm/mach-orion5x/mpp.h |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/mach-orion5x/mpp.h b/arch/arm/mach-orion5x/mpp.h
> > index eac6897..db70e79 100644
> > --- a/arch/arm/mach-orion5x/mpp.h
> > +++ b/arch/arm/mach-orion5x/mpp.h
> > @@ -65,8 +65,8 @@
> >  #define MPP8_GIGE               MPP(8,  0x1, 0, 0, 1,   1,   1)
> >  
> >  #define MPP9_UNUSED		MPP(9,  0x0, 0, 0, 1,   1,   1)
> > -#define MPP9_GPIO		MPP(9,  0x0, 0, 0, 1,   1,   1)
> > -#define MPP9_GIGE               MPP(9,  0x1, 1, 1, 1,   1,   1)
> > +#define MPP9_GPIO		MPP(9,  0x0, 1, 1, 1,   1,   1)
> > +#define MPP9_GIGE               MPP(9,  0x1, 0, 0, 1,   1,   1)
> >  
> >  #define MPP10_UNUSED		MPP(10, 0x0, 0, 0, 1,   1,   1)
> >  #define MPP10_GPIO		MPP(10, 0x0, 1, 1, 1,   1,   1)
> 
> -- 
> Ben Hutchings
> This sentence contradicts itself - no actually it doesn't.



> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter