Re: [PATCH 03/11] ASoC: fsl: add sgtl5000 clock support for imx-sgtl5000
On Wed, May 02, 2012 at 06:50:24PM +0800, Richard Zhao wrote: > On Tue, May 01, 2012 at 09:44:48PM +0800, Shawn Guo wrote: > > > + data->codec_clk = clk_get(&codec_dev->dev, NULL); > > It's a clock of sgtl5000 codec. I feel it makes more sense to have > > sgtl5000 device driver than machine driver to manage this clock. > The ASoC machine driver handled the clock settings, I just followed the > same way, using snd_soc_dai_set_sysclk to set codec clk. But what you > said is reasonable. I also find it's impossible to use devm_get_clk. > Mark, do you suggest get clk in ASoC machine driver or in codec driver? We generally try to keep the clock API out of CODEC drivers due to the issues with the clock API that the generic implementation is intended to help us solve. The major problem here is that we can't rely on having the clock API present at all on most platforms so as soon as we start adding clock support into things we have to do a performance with HAVE_CLK which is at best annoying. There's also the fact that even if the clock API is available we've no way to register a clock consistently and since the audio clock tree often needs management off-SoC for at least some components when the clock API is in use you end up having to handle clock trees that go into and out of the clock API. The upshot of this is that while we really should be using the clock API for clocks the API as it stands is somewhat difficult to deploy in cross platform code. What I'd suggest is connecting the clock to the CODEC in the device tree but actually doing the clk_get() in the machine driver.
Description: Digital signature
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
[Linux ARM (vger)] [Linux ARM MSM] [Linux Omap] [Linux Arm] [Linux Tegra] [Fedora ARM] [eCos] [Linux Fastboot] [Gcc Help] [Git] [DCCP] [IETF Announce] [Security] [PDAs] [Linux] [Linux MIPS] [Yosemite Campsites] [Photos]