Re: [PATCH 05/12] mmc: omap_hsmmc: add DMA engine support

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Apr 23, 2012 at 6:05 PM, Russell King
<rmk+kernel@xxxxxxxxxxxxxxxx> wrote:

> Add DMA engine support to the OMAP HSMMC driver.  This supplements the
> private DMA API implementation contained within this driver, and the
> driver can be switched at build time between using DMA engine and the
> private DMA API.
>
> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>

Great,

> +#if 1
> +               sig = host->dma_line_rx;
> +               host->rx_chan = dma_request_channel(mask, omap_dma_filter_fn, &sig);
> +               if (!host->rx_chan) {
> +                       dev_warn(mmc_dev(host->mmc), "unable to obtain RX DMA engine channel %u\n", sig);
> +               }
> +#endif
> +#if 1
> +               sig = host->dma_line_tx;
> +               host->tx_chan = dma_request_channel(mask, omap_dma_filter_fn, &sig);
> +               if (!host->tx_chan) {
> +                       dev_warn(mmc_dev(host->mmc), "unable to obtain TX DMA engine channel %u\n", sig);
> +               }
> +#endif

Are these development artifacts?

Apart from that:
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel