Re: [PATCH 04/17] ARM: ep93xx: use machine specific hook for late init

[Ryan Mallon <rmallon@xxxxxxxxx>]

On 27/04/12 07:49, H Hartley Sweeten wrote:

> On Thursday, April 26, 2012 2:11 PM, Ryan Mallon wrote:
>> On 27/04/12 01:38, Shawn Guo wrote:
>>
>>> Cc: Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
>>> Cc: Ryan Mallon <rmallon@xxxxxxxxx>
>>> Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
>>
>>
>> Why do we want this? It increases the size of the code and changes
>> a static function to a non-static one that now requires ifdefery
>> to handle the !CONFIG_CRUNCH case. I don't see the value in this
>> patch?
> 
> Ryan,
> 
> See Shawn's "[PATCH 00/17] arch/arm/mach-* late_initcall cleanup".
> 
> I haven't looked closely at this yet. I think there may be some platforms
> where the late_initcall's might cause a problem when making an ARM
> unified kernel.


Hmm, I see. It's a bit annoying that it makes the code less clean, but I
can't really see any other nice way of doing it :-/.

~Ryan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel