Re: imx sgtl5000:BUG: scheduling while atomic: speaker-test/1225/0x00000003

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Thu, Apr 26, 2012 at 10:02:41AM +0200, Lothar Waßmann wrote:
> Hi,
> 
> Sascha Hauer writes:
> > On Thu, Apr 26, 2012 at 09:29:17AM +0200, Lothar Waßmann wrote:
> > > Hi,
> > > 
> > > > > -	init_completion(&sdmac->done);
> > > > > +	unsigned long timeout = 500;
> > > > I'm not sure. Did you test 500us is enough for loading firmware?
> > > >
> > > Channel 0 is not used for actual data transfer but for some internal
> > > housekeeping. Thus the timeout is independent from the time required
> > > for the actual data transfer.
> > > I haven't seen any timeout even with the timeout set to 100us.
> > > Usually it takes 3 to 4 us to complete.
> > 
> > It *is* used to load the firmware. Have you tested your patch with
> > actually loading a firmware?
> > 
> I'm using it around 100 times a day (with a 100us timeout)...

That should be enough ;)

I am fine with the patch.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter