Re: [PATCH V2 4/9] ata/sata_mv: Remove conditional compilation of clk code
Hello. On 24-04-2012 11:05, Viresh Kumar wrote:
I don't think this change is correct. With the old semantics, it was:
If we have CLK support, we expect there to be a clock for sata_mv, and if there is no such clock, output a notice message, something is probably wrong, i expected there to be a clock.
The new semantics are:
We expect there to be a clock for sata_mv, and if there is no such clock, output a notice message, something is probably wrong, i expected there to be a clock.
We are going to see this notice message much more, when it is not expected.
So, the only problem is this message? How do you suggest to tackle this now. Have #ifdef,#endif around this print?
When there's no CONFIG_HAVE_CLK, if clk_get() returns NULL, not error, there'll be no message.
WBR, Sergei _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
[Linux ARM (vger)] [Linux ARM MSM] [Linux Omap] [Linux Arm] [Linux Tegra] [Fedora ARM] [eCos] [Linux Fastboot] [Gcc Help] [Git] [DCCP] [IETF Announce] [Security] [PDAs] [Linux] [Linux MIPS] [Yosemite Campsites] [Photos]