Re: [PATCH 3/8] clk: mxs: add clock support for imx28

["Turquette, Mike" <mturquette@xxxxxx>]

On Sat, Apr 21, 2012 at 8:57 AM, Shawn Guo <shawn.guo@xxxxxxxxxx> wrote:
> Add imx28 clock support based on common clk framework.
>
> Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> ---
...
> +int __init mx28_clocks_init(void)
> +{
> +       struct clk *clk;
> +       int ret;
> +
> +       clk_misc_init();
> +
> +       mxs_clk_fixed("ref_xtal", 24000000);

Hi Shawn,

My comment here is the same as patch 2/8.  There is zero
error handling here.  Registration functions _should_ be returning
-EERROR.

Regards,
Mike

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel