Re: [PATCH] staging: tidspbridge: fix build errors for OMAP2_L4_IO_ADDRESS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Mon, Apr 23, 2012 at 5:39 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:
> On Mon, Apr 23, 2012 at 05:34:14PM +0300, Felipe Contreras wrote:
>> drivers/staging/tidspbridge/core/tiomap3430.c: In function 'bridge_brd_start':
>> drivers/staging/tidspbridge/core/tiomap3430.c:425: error: implicit declaration of function 'OMAP2_L4_IO_ADDRESS'
>> drivers/staging/tidspbridge/core/wdt.c: In function 'dsp_wdt_init':
>> drivers/staging/tidspbridge/core/wdt.c:56: error: implicit declaration of function 'OMAP2_L4_IO_ADDRESS'
>>
>> The proper fix will come later.
>
> Hmm.  Given that this is staging stuff, which hasn't been making much
> progress out of staging, I'd suggest not doing the quick fix on it, but
> spending the time to implement the proper fix now and move the code
> closer to the point where it can move out of staging.

Omar is already on that.

> You might get a gold star from Greg for moving this forward...

In my experience gold stars from Greg mean nothing.

Cheers.

-- 
Felipe Contreras

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter