|
|
Re: [PATCH V2] watchdog: mpcore: Add DT probing support for ARM mpcore watchdog |
On Mon, Apr 23, 2012 at 2:06 PM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote: > Irk! Have you actually tested this? Yes. But with incorrect base address. I passed timers address by mistake. > The DT binding indicates: > - reg : Specify the base address and the size of the TWD watchdog > register window. > > while all the offsets in smp_twd.h are expressed in bytes from the TWD > *timer* base. So you have to either fix these offsets (which breaks > potential users of the non-DT version of the driver), or correct the > base when using DT. You are correct. Which one do you prefer: - Change bindings to pass timers base address - subtract 0x20 from base address for DT case - something else. -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
[Linux ARM (vger)] [Linux ARM MSM] [Linux Omap] [Linux Arm] [Linux Tegra] [Fedora ARM] [eCos] [Linux Fastboot] [Gcc Help] [Git] [DCCP] [IETF Announce] [Security] [PDAs] [Linux] [Linux MIPS] [Yosemite Campsites] [Photos]
|
|