Re: [PATCH] gpio: pxa: Set PXA GPIO irq_chip IRQCHIP_SKIP_SET_WAKE flag

[Robert Jarzmik <robert.jarzmik@xxxxxxx>]

Haojian,

I feel there's some change in PXA gpio wakeup handling that's weird.

The effect : gpio_keys driver can't wakeup from suspend to RAM on GPIO0
activation

A quick analysis (thanks Paul for direction) :
 - gpio_keys() calls irq_set_wake(96, 1) (ie. gpio0)
 - gpio-pxa driver doesn't care (as it doesn't have any irq_set_wake function)
   (see in [1])

Now if I'm directing the mail at is because you're the only one who commited
between v3.2 and v3.3 in gpio-pxa driver ([2]).

Could you tell me if removing irq_set_wake() was intentional ?

Cheers.

-- 
Robert

[1]
rj@beldin:~/mio_linux/kernel$ git show v3.2:drivers/gpio/gpio-pxa.c | grep set_wake
void __init pxa_init_gpio(int mux_irq, int start, int end, set_wake_t fn)
	pxa_muxed_gpio_chip.irq_set_wake = fn;
rj@beldin:~/mio_linux/kernel$ git show v3.3:drivers/gpio/gpio-pxa.c | grep set_wake
rj@beldin:~/mio_linux/kernel$ 

[2]
rj@beldin:~/mio_linux/kernel$ git log v3.3 ^v3.2 --pretty=format:%an drivers/gpio/gpio-pxa.c | sort -u
Haojian Zhuang

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel