Re: [PATCH 10/17][V2] ARM: OMAP3: cpuidle - remove the 'valid' field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On 04/10/2012 01:13 AM, Kevin Hilman wrote:
Daniel Lezcano<daniel.lezcano@xxxxxxxxxx>  writes:

With the previous changes all the states are valid, except
the last state which can be handled by decreasing the number
of states.

Signed-off-by: Daniel Lezcano<daniel.lezcano@xxxxxxxxxx>
Reviewed-by: Jean Pihet<j-pihet@xxxxxx>

[ ... ]

-		cx->valid = 0;
+		drv->state_count = OMAP3_NUM_STATES - 1;
  		pr_warn("%s: core off state C7 disabled due to i583\n",

I'm not too particular about this one, but it might be cleaner to just
remove this check all together.  This errata already has a check in
next_valid_state() so strictly speaking, it's not needed here.

Yes, right. Thanks for pointing this.

 <> │ Open source software for ARM SoCs

Follow Linaro:  <> Facebook |
<!/linaroorg> Twitter |
<> Blog

linux-arm-kernel mailing list

[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter