Re: [PATCH 02/12] ARM: Exynos5: Fix incorrect initialization of GIC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Thomas Abraham wrote:
> Use the of_irq_init() call to setup the gic which also properly registers
> the gic device node pointer with gic irq domain, without which all interrupt
> specifier translations for gic fail.
> 
> Signed-off-by: Thomas Abraham<thomas.abraham@xxxxxxxxxx>
> ---
>   arch/arm/mach-exynos/common.c |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
> index 636d5f8..35ac675 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -532,11 +532,12 @@ void __init exynos4_init_irq(void)
>   	s5p_init_irq(NULL, 0);
>   }
> 
> +#ifdef CONFIG_ARCH_EXYNOS5

Why this is needed?

>   void __init exynos5_init_irq(void)
>   {
>   	int irq;
> 
> -	gic_init(0, IRQ_PPI(0), S5P_VA_GIC_DIST, S5P_VA_GIC_CPU);
> +	of_irq_init(exynos4_dt_irq_match);
> 
>   	for (irq = 0; irq<  EXYNOS5_MAX_COMBINER_NR; irq++) {
>   		combiner_init(irq, (void __iomem *)S5P_VA_COMBINER(irq),
> @@ -551,6 +552,7 @@ void __init exynos5_init_irq(void)
>   	 */
>   	s5p_init_irq(NULL, 0);
>   }
> +#endif /* CONFIG_ARCH_EXYNOS5 */
> 
>   struct bus_type exynos4_subsys = {
>   	.name		= "exynos4-core",

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter