Re: [PATCH V5 0/4] ARM: Kirkwood: Add support for DNS-320 and DNS-325 using devicetree
On Wed, Apr 18, 2012 at 03:24:45PM +0200, Andrew Lunn wrote:> > dies at "Gating clock of unused units", presumably as CGC_RUNIT isn't set.> > Is this something known or is it worth further investigation? >> That could potentially mess up a future bisect. However, it would only> crop up for dnskw boards. I'll let Grant weigh in on this since he's > the one who asked that the nand init be removed. Turning off RUNIT is bad. Both the NAND and SPI controllers use this clock. You can only safely turn it off if none of these are active.
So would u-boot using the NAND count as the controller being active in this case?
If we hear no objections, call kirkwood_nand_init() with no partition entries, then put the partition entries in the commandline in the dts. This is what Arnaud Patard is doing with the Iomega iConnect: mtdparts=orion_nand:0xc0000@0x0(uboot),0x20000@0xa0000(env),0x300000@0x100000(zImage),0x300000@0x540000(initrd)... Then, in the last patch remove the mtdparts from the commandline in the dts and add the partition entries appropriately.
Certainly can do, although I'm not entirely convinced it addresses Grant's comment. Another option would be to change the patch order and add DNS-320 support after all NAND support patches are merged, although that would go against the initial advice of how to layout the patchset. Will do whatever is considered best though.
-- Jamie Lentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
[Linux ARM (vger)] [Linux ARM MSM] [Linux Omap] [Linux Arm] [Linux Tegra] [Fedora ARM] [eCos] [Linux Fastboot] [Gcc Help] [Git] [DCCP] [IETF Announce] [Security] [PDAs] [Linux] [Linux MIPS] [Yosemite Campsites] [Photos]