Re: [PATCH] ARM: omap: hwmod: warn only when clkdm is missing from both clk and hwmod

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Hi Paul,

On 4/12/2012 7:06 PM, Paul Walmsley wrote:

On Thu, 12 Apr 2012, Rajendra Nayak wrote:

On OMAP4+, the clkdm association is moved to hwmod while on older OMAPs'
its associated with a clk.

Sounds like this should be conditional based on the platform, then,
rather than weakening the warning for all platforms ?

Well, as already discussed the clockdomain information is mostly useless for most clock nodes because the HW is taking care of the dependencies, so highlighting only the ones missing in hwmod is far from enough and will avoid scaring people with something that is normal.

Considering that OMAP4 clock domain partition is way more complex than it was on OMAP2 & 3, if OMAP4 can leave without that, I doubt OMAP2 & 3 clock nodes will ever need it, except HW bugs, as usual.

But still, it is an exception more than the regular case.

Hence look for a clkdm in both clk and hwmod and warn only when
its missing in both. Also fix the pr_warning() to print the correct
hwmod name.

Signed-off-by: Rajendra Nayak<rnayak@xxxxxx>

Acked-by: Benoit Cousson <b-cousson@xxxxxx>


linux-arm-kernel mailing list

[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter