Re: [PATCH v3 1/3] USB: Add driver for NXP ISP1301 USB transceiver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 17 April 2012, Roland Stigge wrote:
> +static int match(struct device *dev, void *data)
> +{
> +       struct device_node *node = (struct device_node *)data;
> +       return dev->of_node == node ? 1 : 0;
> +}

One small correction: you should probably check if the device
is actually bound to isp1301_driver:

	return (dev->of_node == node) && (dev->driver == &isp1301_driver.driver);

Otherwise, the changes from last version look all good.

	Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [CentOS ARM]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]

  Powered by Linux