Re: [PATCH 02/10] clk: remove unnecessary EXPORT_SYMBOL_GPL

[Shawn Guo <shawn.guo@xxxxxxxxxx>]

On Tue, Mar 27, 2012 at 11:28:28AM +0200, Andrew Lunn wrote:
> > Date: Tue, 27 Mar 2012 15:23:21 +0800
> > From: Shawn Guo <shawn.guo@xxxxxxxxxx>
> > To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Cc: Shawn Guo <shawn.guo@xxxxxxxxxx>, Mike Turquette
> >        <mturquette@xxxxxxxxxx>
> > Subject: [PATCH 02/10] clk: remove unnecessary EXPORT_SYMBOL_GPL
> > Message-ID: <1332833009-4121-3-git-send-email-shawn.guo@xxxxxxxxxx>
> >
> > It makes no sense to have EXPORT_SYMBOL_GPL on static functions.
> 
> Hi Shawn
> 
> I agree, exporting static functions makes no sense.
> 
> However, i think it would be good to export them. I will probably need
> to build a clk very similar to the gated clock. I would like to use
> these functions when building my ops structure and just add wrappers
> around them where needed.
> 
> Could you instead remove the static?
> 
Hmm, I would not.

I have a similar need for clk_divider_ops calls.  Instead of exporting
every single clk_gate_ops call, we should just export "struct clk_ops
clk_gate_ops".  That's exactly why I have the patch #4 here.

-- 
Regards,
Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel