Re: [alsa-devel] [PATCH v3 09/11] ASoC: fsl: remove the fatal error checking on codec-handle

[Trent Piepho <tpiepho@xxxxxxxxx>]

On Thu, Mar 15, 2012 at 11:39 AM, Trent Piepho <tpiepho@xxxxxxxxx> wrote:
> On Thu, Mar 15, 2012 at 10:21 AM, Shawn Guo <shawn.guo@xxxxxxxxxx> wrote:
>> On Thu, Mar 15, 2012 at 01:37:06PM +0000, Tabi Timur-B04825 wrote:
>> ...
>> > The PowerPC MPC8610 has two SSIs, and I have a hacked up board that has
>> > both connected to two CS4270s.  This is how I tested multiple SSI support
>> > in my driver.
>> >
>> > Since my driver supports any number of SSIs, I expect any changes to it to
>> > continue that support.
>> >
>> I think it can still easily get supported with the binding like below.
>>
>> sound {
>>      compatible = "fsl,imx51-babbage-sgtl5000",
>>                   "fsl,imx-audio-sgtl5000";
>>      model = "imx51-babbage-sgtl5000";
>>      ssi-controller = <&ssi1, &ssi2>;
>>      audio-codec = <&sgtl5000_1, &sgtl5000_2>;
>>      mux-int-port = <1>;
>>      mux-ext-port = <3>;
>> };
>
> How would you support binding the imx51 ESAI controller?

Sorry about previous email, laptop touchpad emitted a spurious click,
which caused text window in gmail to become deselected, which caused a
subsequent enter to send the email rather than creating a new line.

For esai, would you add something like:
    esai-controller = <&esai1>;
    esai-audio-codec = <&sgtl5000_3>;

That seems rather ugly to me.

It seems to me in most device bindings where one piece of hardware is
attached to another, than the one upstream has in its binding a
phandle to the one downstream.  But here we have a third binding with
two lists of devices and an implied link between devices in
corresponding positions in the lists.  Does any other device binding
work like that?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel