Re: [PATCH 02/10] ARM: ux500: Initial Device Tree support for Snowball

[Arnd Bergmann <arnd@xxxxxxxx>]

On Wednesday 14 March 2012, Lee Jones wrote:
> 
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> This provides very basic Device Tree support for ST-Ericsson's
> low-cost development platform, Snowball. If Device Tree for
> ux500 is enabled and the correct board is configured within the
> Device Tree blob, the correct *_init_machine() will be called.
> 
> This patch is based on some original work completed by:
>   Niklas Hernaeus <niklas.hernaeus@xxxxxxxxxx>
> 
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> Signed-off-by: Niklas Hernaeus <niklas.hernaeus@xxxxxxxxxx>

As mentioned on IRC, the order of the S-o-B should be such that the
person submitting a patch comes last, so this one should be

Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Signed-off-by: Niklas Hernaeus <niklas.hernaeus@xxxxxxxxxx>
Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

or maybe

Signed-off-by: Niklas Hernaeus <niklas.hernaeus@xxxxxxxxxx>
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

The patch itself looks good to me, but that is not surprising,
given that I wrote it ;-).

	Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel