Re: [PATCH 1/7] Add various hugetlb arm high level hooks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On 2012年02月29日 23:38, Catalin Marinas wrote:
On Wed, Feb 29, 2012 at 11:28:30AM +0000, bill4carson wrote:
On 2012年02月29日 18:32, Catalin Marinas wrote:
On Mon, Feb 13, 2012 at 09:44:22AM +0000, Bill Carson wrote:
+static inline void huge_ptep_set_wrprotect(struct mm_struct *mm,
+					   unsigned long addr, pte_t *ptep)
+	pte_t old_pte = *ptep;
+	set_huge_pte_at(mm, addr, ptep, pte_wrprotect(old_pte));

You could use the generic ptep_set_wrprotect()

I'm a bit of confused about this.

generic ptep_set_wrprotect() can not set huge pte, that's why
set_huge_pte_at is used instead here.

Ah, the generic one can only work with with LPAE where set_huge_pte_at()
is just a set_pte_at(). So this part looks good.

Hi, Catalin

Thanks for your time to review PATCH1/7 :)

I'm wondering if reset of this patch set is ok,
I would like to start working on V3 as per your comments.

I am a slow learner
but I will keep trying to fight for my dreams!


linux-arm-kernel mailing list

[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter