Re: [PATCH v2 0/9] DMA engine cookie handling cleanups

[Jassi Brar <jassisinghbrar@xxxxxxxxx>]

On Wed, Mar 7, 2012 at 11:51 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:
> On Wed, Mar 07, 2012 at 11:39:25PM +0530, Jassi Brar wrote:
>> Compilation is broken without the following minor fix.
>> After that you may add
>>        Acked-by: Jassi Brar <jassisinghbrar@xxxxxxxxx>
>>
>> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
>> index 49c123f..abf35a3 100644
>> --- a/drivers/dma/pl330.c
>> +++ b/drivers/dma/pl330.c
>> @@ -339,7 +339,6 @@ static int pl330_control(struct dma_chan *chan,
>> enum dma_ctrl_cmd cmd, unsigned
>>               /* Mark all desc done */
>>               list_for_each_entry_safe(desc, _dt, &pch->work_list , node) {
>>                       desc->status = DONE;
>> -                     pch->completed = desc->txd.cookie;
>
> I'm not sure just removing this is sufficient.  Presumably it's
> there for some reason - maybe it needs replacing with a call to
> dma_cookie_complete() to preserve existing behaviour?
>
That was anyway a redundant save in DMA_TERMINATE_ALL, so it should be ok.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel