Re: [PATCH 1/7] Add various hugetlb arm high level hooks
On 2012年02月29日 01:30, Catalin Marinas wrote:
On Mon, Feb 13, 2012 at 09:44:22AM +0000, Bill Carson wrote:diff --git a/arch/arm/include/asm/page.h b/arch/arm/include/asm/page.h index 97b440c..3e6769a 100644 --- a/arch/arm/include/asm/page.h +++ b/arch/arm/include/asm/page.h @@ -15,6 +15,21 @@ #define PAGE_SIZE (_AC(1,UL)<< PAGE_SHIFT) #define PAGE_MASK (~(PAGE_SIZE-1)) +#ifdef CONFIG_HUGEPAGE_SIZE_2MB +/* we have 2MB hugepage for two 1MB section mapping */ +#define HPAGE_SHIFT (SECTION_SHIFT + 1) +#define HPAGE_SIZE (_AC(1, UL)<< HPAGE_SHIFT) +#define HPAGE_MASK (~(HPAGE_SIZE - 1)) +#define HUGETLB_PAGE_ORDER (HPAGE_SHIFT - PAGE_SHIFT) +#endif + +#ifdef CONFIG_HUGEPAGE_SIZE_16MB +#define HPAGE_SHIFT SUPERSECTION_SHIFT +#define HPAGE_SIZE (_AC(1, UL)<< HPAGE_SHIFT) +#define HPAGE_MASK (~(HPAGE_SIZE - 1)) +#define HUGETLB_PAGE_ORDER (HPAGE_SHIFT - PAGE_SHIFT) +#endifAh, you still have these just config time options. Can you not make an hpage_shift variable like PowerPC or IA-64?
Hi, Catalin Thank you for reviewing this patch. unsigned int hpage_shift = SECTION_SHIFT + 1; /* default to 2MB page */ #define HPAGE_SHIFT hpage_shift then user could configure hpage_shift through "hugepagesz" parameter. I think this is what I am supposed to do, If so, hugepage_setup_sz/cpu_v7_set_hugepte_ext needs modification
(I haven't yet reviewed the rest of the code)
So, should I send another version now, or wait until you walk through the reset of patch set? And again, thanks for the patch reviewing:) -- I am a slow learner but I will keep trying to fight for my dreams! --bill _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
[Linux ARM (vger)] [Linux ARM MSM] [Linux Omap] [Linux Arm] [Linux Tegra] [Fedora ARM] [eCos] [Linux Fastboot] [Gcc Help] [Git] [DCCP] [IETF Announce] [Security] [PDAs] [Linux] [Linux MIPS] [Yosemite Campsites] [Photos]