Re: [PATCH v5 1/9] cpuidle: Add commonly used functionality for consolidation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

> I brought this topic up internally and Jon suggested that the 'usage'
> statistics that are reported in sysfs should also reflect failed
> versus successful C-state transitions, which is a great idea.  This
> could simply be achieved by renaming the current 'usage' count to
> something like 'transitions_attempted' and then conditionally
> increment a new counter within the 'if (entered_state >= 0)' block,
> perhaps named, 'transition_succeeded'.
> This way the old 'usage' count paradigm is as accurate as the new
> time-keeping code.  Being able to easily observe which C-state tend to
> fail the most would be invaluable in tuning idle policy for maximum
> effectiveness.
> Thoughts?

Sounds reasonable.  In some cases it may be helpful to track state
demotion as well.  Since I'm still a noob and wearing my submission
training wheels, I'm trying to minimize things that fall outside of
this basic consolidation effort for this patch series.  But I added
Jon's suggestion to this cpuidle page which contains future cpuidle
items to consider adding:

> Regards,
> Mike
>>> Regards,
>>> Mike

linux-arm-kernel mailing list

[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter