Re: [PATCH v3 0/2] Device tree support for TWL regulators

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On 2/27/2012 3:03 PM, Mark Brown wrote:
On Mon, Feb 27, 2012 at 02:52:05PM +0100, Cousson, Benoit wrote:
On 2/27/2012 2:41 PM, Mark Brown wrote:
On Mon, Feb 27, 2012 at 06:01:20PM +0530, Rajendra Nayak wrote:

Please can you guys come up with a single unified series for this stuff
- I'll hold off on applying anything to allow you to do this.

The issue is that the initial TWL regulator series from Rajendra
will depend on the twl core DT support I have that depends on the
irq_domain series from Grant...

Really?  That's the first I've heard of any such dependency here.  Is it
a build time dependency or is it just something that's required to make
the code actually spring into life?  It looks like it's the latter but
you're saying there's an actual dependency.

Mmm, it is written in Rajendra's changelog:

"-2- All common regulator nodes for twl4030 and twl6030 are
now defined in the twl4030.dtsi and twl6030.dtsi instead of
repeating the nodes in all board files, which also means
the patch ('arm/dts: twl: Pass regulator data from dt')
has a dependency with the series from Benoit which adds the
twl4030.dtsi and twl6030.dtsi files[2]."

The good point is that a missing or broken DTS will indeed not break the build, it will just not boot the platform properly. But that still an important dependency to me.

There's also more than that, there's also at least Tero submitting some
other stuff separately (and his stuff won't play with DT...) and I think
Peter also.  It really fees like there's a bunch of people working on
different things without talking to each other here.

That's the problem with MFD devices that are doing everything from audio to power including the coffee...

So I guess, it will be easy for us to split the regulator patches
from the DTS ones to have at least the driver changes merged by you.
Then Tony might be able to pull all the DTS in one series and thus
avoid the various merge conflict that will happen since most OMAP
drivers are hacking the same DTS files.

Does that make sense? Or do you think it will be even worst
separating the patches?

Unless there's a compile time dependency I don't think we need to
refactor anything here, what I'm seeing at the minute looks OK from a
merge point of view except that there appears to be a lack of
coordination between the various serieses.

Fair enough on that point. At least now we have all the stakeholders, so let's do some TI internal laundry.

Regards,
Benoit



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter