Re: [PATCH 2/3] ARM: PXA27x: save/restore PWER on suspend/resume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Sun, Feb 26, 2012 at 05:55:09PM +0300, Vasily Khoruzhick wrote:
> 2012/2/26 Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>:
> > On Sun, Feb 26, 2012 at 04:47:41PM +0300, Vasily Khoruzhick wrote:
> >> Bootloader can clobber PWER value, so save it state on suspend.
> >
> > What boot loader is this, and why is it being so idiotic?  Why can't it
> > be fixed?
> I'm using u-boot on this machine...
> Hmm, I've looked throuhg its sources and did not find where it can clobber it.
> But PWER register value is not preserved across suspend for some reason
> (at least bit 0). Maybe it's some conflict with gpiolib? But
> gpio_set_wake() doesn't work
> for me on PXA.

It sounds like some more debugging is required.

I assume that you've done some basic things, such as:

(1) checking the return value of gpio_set_wake()
(2) checking what's going on internally in gpio_set_wake()

Most users of gpio_set_wake() do not seem to check its return value, so
if it fails you'll never know about it except by seeing incorrect values
in PWER.

linux-arm-kernel mailing list

[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter