Re: [PATCH 4/4] ASoC: fsl: make fsl_ssi driver compilable on ARM/IMX

Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> · Thu, 23 Feb 2012 19:24:35 +0400

Hello.

On 23-02-2012 18:48, Shawn Guo wrote:


Change PowerPC dependent IO accessors to architecture independent
ones, so that fsl_ssi driver can be built on both PowerPC and ARM/IMX.



Signed-off-by: Shawn Guo<shawn.guo@xxxxxxxxxx>
---
  sound/soc/fsl/fsl_ssi.c |   75 ++++++++++++++++++++++++++++------------------
  1 files changed, 46 insertions(+), 29 deletions(-)

diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 3e06696..32fc84b 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c

[...]

@@ -145,7 +148,7 @@ static irqreturn_t fsl_ssi_isr(int irq, void *dev_id)
  	   were interrupted for.  We mask it with the Interrupt Enable register
  	   so that we only check for events that we're interested in.
  	 */
-	sisr = in_be32(&ssi->sisr) & SIER_FLAGS;
+	sisr = readl(&ssi->sisr) & SIER_FLAGS;



   These functions are not equivalent concerning endianness. You should 

probably have used readl_be() instead, else it won't work on PPC anymore.


WBR, Sergei

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

