Re: [PATCH v3 1/2] mxs-dma : move the mxs dma.h to a more common place

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Tue, Feb 07, 2012 at 06:54:34PM +0800, Huang Shijie wrote:
> Move the header to a more common place.
> The mxs dma engine is not only used in mx23/mx28, but also used
> in mx50/mx6q.  It will also be used in the future chips.
> 
> Rename it to mxs-dma.h
> 
> change mxs-dma driver, mxs-mmc driver, gpmi-nand driver, mxs-saif driver
> to the new header file.
> 
> Signed-off-by: Huang Shijie <b32955@xxxxxxxxxxxxx>
> ---
>  drivers/dma/mxs-dma.c                              |    2 +-
>  drivers/mmc/host/mxs-mmc.c                         |    2 +-
>  drivers/mtd/nand/gpmi-nand/gpmi-nand.h             |    2 +-
>  .../include/mach/dma.h => include/linux/mxs-dma.h  |    0
>  sound/soc/mxs/mxs-pcm.c                            |    2 +-
>  sound/soc/mxs/mxs-pcm.h                            |    2 +-
>  sound/soc/mxs/mxs-saif.c                           |    2 +-
>  7 files changed, 6 insertions(+), 6 deletions(-)
>  rename arch/arm/mach-mxs/include/mach/dma.h => include/linux/mxs-dma.h (100%)

I suggested you rename it include/linux/fsl/mxs-dma.h [1].  It seems
you are ignoring the comment.  Can you explain why it's not a
reasonable suggestion?

And Wolfram and Mark told you that you need to Cc subsystem maintainers
to collect their acks [2].  But you are still not Ccing Mark Brown and
Chris Ball for sound/soc/ and drivers/mmc changes.  So you are not
listening.

Regards,
Shawn

[1] http://article.gmane.org/gmane.linux.kernel.mmc/12301
[2] http://article.gmane.org/gmane.linux.alsa.devel/93751

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter