Re: [PATCH 05/16] ARM: omap: fix vc.c PMIC error message

[Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>]

On Wed, Feb 08, 2012 at 03:53:58PM -0800, Tony Lindgren wrote:
> * Kevin Hilman <khilman@xxxxxx> [120208 14:35]:
> > Tony Lindgren <tony@xxxxxxxxxxx> writes:
> > 
> > > * Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> [120208 08:06]:
> > >> While testing on my OMAP3430 platform, this error message was emitted:
> > >> 
> > >> omap_vc_init_channel: PMIC info requried to configure vc forvdd_core not populated.Hence cannot initialize vc
> > >> 
> > >> Trying to find this message was difficult because it was wrapped across
> > >> several lines.  It also mis-spells "required", doesn't read very well,
> > >> and has spaces lacking.  Let's replace it with a more concise:
> > >> 
> > >> omap_vc_init_channel: No PMIC info for vdd_core
> > >> 
> > >> While we're here, fix a simple spelling error in a comment.
> > >> 
> > >> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
> > >
> > > Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
> > 
> > NAK.
> > 
> > Tony, please use the patches already in your cleanup branch (that came
> > from my for_3.3/cleanup/pm) that fix this and also fix a similar problem
> > for VP.
> 
> Ah OK, there's the VP part there too.
> 
> So that would be the following two patches then for me to
> move to fixes from cleanup:
> 
> cd63040e00ea83729673acfea1675d85fde6ea59 ARM: OMAP: voltage: cleanup VC/VP error messages
> af9a2ed9667b49e7e125eac526d8f655183ce53e ARM: OMAP2+: voltage: add check for missing PMIC info in VP init
> 
> And patches 1 and 5 for Russell to drop then.
> 
> Everybody OK with that?

Does it fix the other issues I mention in the commit log as well?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel