Re: [PATCH] Added phy3250_defconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Thu, Jan 26, 2012 at 04:47:45PM +0100, Roland Stigge wrote:
> diff --git a/arch/arm/mach-lpc32xx/common.c b/arch/arm/mach-lpc32xx/common.c
> index 369b152..6b9b3e0 100644
> --- a/arch/arm/mach-lpc32xx/common.c
> +++ b/arch/arm/mach-lpc32xx/common.c
> @@ -164,7 +164,7 @@ int clk_is_sysclk_mainosc(void)
>  /*
>   * System reset via the watchdog timer
>   */
> -static void lpc32xx_watchdog_reset(void)
> +void lpc32xx_watchdog_reset(void)

That's a build fix, and so should be a separate patch from other changes.

>  {
>  	/* Make sure WDT clocks are enabled */
>  	__raw_writel(LPC32XX_CLKPWR_PWMCLK_WDOG_EN,
> diff --git a/arch/arm/mach-lpc32xx/phy3250.c b/arch/arm/mach-lpc32xx/phy3250.c
> index bfee5b4..f4ea653 100644
> --- a/arch/arm/mach-lpc32xx/phy3250.c
> +++ b/arch/arm/mach-lpc32xx/phy3250.c
> @@ -381,7 +381,7 @@ static int __init lpc32xx_display_uid(void)
>  }
>  arch_initcall(lpc32xx_display_uid);
>  
> -MACHINE_START(PHY3250, "Phytec 3250 board with the LPC3250 Microcontroller")
> +MACHINE_START(LPC3XXX, "Phytec 3250 board with the LPC3250 Microcontroller")

This looks wrong.  Please explain this change; the ID is supposed to be
the board number, not related to the SoC.  As this is for the phytec 3250
board, the original looks more correct to me.

Plus, changing this potentially breaks working setups which are using the
PHY3250 ID.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter