RE: [PATCHv2 resend] Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Denis Kuzmenko wrote:
> 
> Hi Kukjin,
> 
Hi Denis,

> Your patch applies (note that it looks like your email-client have

Yeah, if over 76 columns, my e-mail client changes its line so maybe
happened wrapped long lines.

> wrapped long lines thus broke the path) and works OK. Looks good to me.
> See some additional comments below.
> 
> On 12/28/2011 09:59 AM, Kukjin Kim wrote:
> > Denis Kuzmenko wrote:
> (snip)
> >> +	depends on CPU_FREQ_S3C24XX && (S3C2410_IOTIMING ||
> >> S3C2412_IOTIMING)
> >
> > As you know, CONFIG_CPU_FREQ_S3C24XX_IODEBUG is for enabling of
> > s3c_freq_iodbg() and there is no problem when
> CONFIG_S3C241{0,2}_IOTIMING is
> > not selected, even though s3c_freq_iodbg() is used only at
> > s3c2410-iotiming.c now. So this is not necessary to fix the problem you
> > said.
> 
> I'm OK with this approach, however I don't see any future use of
> s3c_freq_iodbg() without s3c2410-iotiming.c. But it's not anyway
> critical so please pick any variant which you like.
> 
Yes. I think we need to sort out the CPUFREQ on S3C24XX next time :)

(snip)

> (snip)
> > So how about at below?
> > If you're ok, will send before v3.2.
> 
> So, as already said, I have no objections.
> And thank you for review.
> 

Thanks and Happy New Year!

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter