Re: [RFT/PATCH 7/7] arm: omap: smartreflex: micro-optimization for sanity check

[Felipe Balbi <balbi@xxxxxx>]

On Tue, Oct 11, 2011 at 03:22:33PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 10-10-2011 16:26, Felipe Balbi wrote:
> 
> >val&&  (val != 1) == val>  1
> 
> >Signed-off-by: Felipe Balbi<balbi@xxxxxx>
> >---
> >  arch/arm/mach-omap2/smartreflex.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> >diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
> >index 7bdabfa..4b0d6a8 100644
> >--- a/arch/arm/mach-omap2/smartreflex.c
> >+++ b/arch/arm/mach-omap2/smartreflex.c
> >@@ -866,7 +866,7 @@ static int omap_sr_autocomp_store(void *data, u64 val)
> >  	}
> >
> >  	/* Sanity check */
> >-	if (val&&  (val != 1)) {
> >+	if (val>  1) {
> >  		pr_warning("%s: Invalid argument %lld\n", __func__, val);
> 
>    The format specified should be "%llu"?

and what does that have to do with $SUBJECT ??

-- 
balbi

Attachment: signature.asc
Description: Digital signature

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel