Re: [PATCH 1/2] ASoC: omap: Add hardware constraint for HDMI and ABE

[Liam Girdwood <lrg@xxxxxxxxxxxxxxx>]

On Wed, 2010-12-08 at 11:11 +0200, Peter Ujfalusi wrote:
> On Tuesday 07 December 2010 10:57:24 Ujfalusi Peter (Nokia-MS/Tampere) wrote:
> > On Tuesday 07 December 2010 00:34:44 ext Olaya, Margarita wrote:
> > > From: Jorge Eduardo Candelaria <jorge.candelaria@xxxxxx>
> > > 
> > > The Audio Backend needs a step size of 24 * 4, while HDMI requires a
> > > step size of 32 * 4 bits to align the audio buffer.
> 
> ...
> 
> > Few things:
> > This only applicable for OMAP4, so please make it so that it only applies
> > to OMAP4.
> > We have the other constraints set in the
> > omap-mcbsp.c:omap_mcbsp_dai_startup. I think it would be better to keep
> > them in a same place.
> 
> One more thing:
> Since this is ABE/HDMI specific constraint, I would add this from the 
> corresponding codec driver rather than setting this for all McBSP ports 
> regardless if it is used with HDMI or not.
> 

I've spoken with Magi and this will be moved to the OAMP4 HDMI and ABE
DAI drivers only.

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel