Re: [PATCH] ALSA: hda - Always allow basic audio irrespective of ELD info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


At Tue, 07 Dec 2010 21:11:03 +0200,
Anssi Hannula wrote:
> 
> On 07.12.2010 21:09, Takashi Iwai wrote:
> > At Tue,  7 Dec 2010 20:56:19 +0200,
> > Anssi Hannula wrote:
> >>
> >> Commit bbbe33900d1f3c added functionality to restrict PCM parameters
> >> based on ELD info (derived from EDID data) of the audio sink.
> >>
> >> However, according to CEA-861-D no SAD is needed for basic audio
> >> (32/44.1/48kHz stereo 16-bit audio), which is instead indicated with a
> >> basic audio flag in the CEA EDID Extension.
> >>
> >> The flag is not present in ELD. However, as all audio capable sinks are
> >> required to support basic audio, we can assume it to be always
> >> available.
> >>
> >> Fix allowed audio formats with sinks that have SADs (Short Audio
> >> Descriptors) which do not completely overlap with the basic audio
> >> formats (there are no reports of affected devices so far) by always
> >> assuming that basic audio is supported.
> >>
> >> Reported-by: Stephen Warren <swarren@xxxxxxxxxx>
> >> Signed-off-by: Anssi Hannula <anssi.hannula@xxxxxx>
> >> ---
> >>
> >> Tested on 2.6.36 and I saw no obvious regressions.
> >>
> >> The issue affects stable 2.6.36 as well, but as there are no reports of
> >> affected devices, I'll leave the decision on whether to send this to
> >> stable@ for the ALSA subsystem maintainers.
> > 
> > I'm inclined for adding stable in this case, because this is more
> > "safer" move for users.
> 
> Agreed.
> 
> > Will the patch "ALSA: hda - Do not wrongly restrict min_channels based
> > on ELD" be resent or shall I apply it as is now together with this?
> 
> IMO it is ok as is.

OK, applied both patches now.
Thanks!


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


[ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

Add to Google Powered by Linux