Re: [PATCH 02/15] ASoC: twl6040: Modify the IRQ handler

[Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Dec 06, 2010 at 06:17:44PM -0600, Olaya, Margarita wrote:

> +	if (intid & TWL6040_PLUGINT)
> +		dev_alert(codec->dev, "headset plug detection\n");
> +
> +	if (intid & TWL6040_UNPLUGINT)
> +		dev_alert(codec->dev, "headset unplug detection\n");

This is where I'd expect to see the jack detection patch adding handling
of the IRQ.

dev_alert() seems too much also - it would usually mean that something
went seriously wrong (like the over current warnings).

>  	return IRQ_HANDLED;
>  }

I'd expect this only if we actually detected (and therefore handled) an
event?
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel