Re: [PATCH] ASoC: mcbsp: Add McBSP support for OMAP4

[Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx>]

On Tuesday 07 December 2010 00:34:40 ext Olaya, Margarita wrote:
> @@ -623,6 +652,9 @@ static int omap_mcbsp_dai_set_dai_sysclk(struct
> snd_soc_dai *cpu_dai, if (cpu_class_is_omap1()) {
>  			err = -EINVAL;
>  			break;
> +		} else if (cpu_is_omap44xx()) {
> +			regs->srgr2     |= CLKSM;
> +			break;

Are you sure about this?
You want to select FCLK as functional clock...
So I think you want to have the source from CLKS, and CLKS should have the 
FCLK selected, so I think you want:
~CLKSM in srgr2, and ~CLKME in pcr0

>  		}
>  		err = omap2_mcbsp_set_clks_src(mcbsp_data->bus_id,
>  					       MCBSP_CLKS_PRCM_SRC);


-- 
Péter
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel