Re: [PATCH] ASoC: Add post-CODEC bias level callback for machine driver

[Liam Girdwood <lrg@xxxxxxxxxxxxxxx>]

On Sat, 2010-12-04 at 12:49 +0000, Mark Brown wrote:
> Currently the machine driver can only do bias level configuration before
> the CODEC bias level is brought up. This means that the machine cannot do
> any configuration which depends on the CODEC bias level being maintained.
> Provide a post-CODEC callback which allows the machine driver to do things
> like enable the FLL on a CODEC which is brought down to BIAS_OFF when idle.
> 
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

Acked-by: Liam Girdwood <lrg@xxxxxxxxxxxxxxx>

> ---
>  include/sound/soc.h  |    2 ++
>  sound/soc/soc-dapm.c |    4 ++++
>  2 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/include/sound/soc.h b/include/sound/soc.h
> index 0eea08e..4abc2f8 100644
> --- a/include/sound/soc.h
> +++ b/include/sound/soc.h
> @@ -632,6 +632,8 @@ struct snd_soc_card {
>  	/* callbacks */
>  	int (*set_bias_level)(struct snd_soc_card *,
>  			      enum snd_soc_bias_level level);

I wonder if it's best we now make this 

set_bias_level_pre() ?

to avoid any confusion.

Liam

-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel