Re: [PATCH 3/3] ASoC: SAMSUNG: Match spdif source clock id and asoc platform device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Fri, Dec 3, 2010 at 8:44 PM, Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Dec 03, 2010 at 06:37:47PM +0900, Seungwhan Youn wrote:
>> This patch modify to match ids between source clock id and asoc platform
>> device that spdif driver can find sclk_audio0 with device id.
>
> Something's seriously wrong if you need to do this...
>
>> - Â Â smdk_snd_spdif_device = platform_device_alloc("soc-audio", -1);
>> + Â Â smdk_snd_spdif_device = platform_device_alloc("soc-audio", 0);
>
> ...the soc-audio device is a virtual device so should have no clocks
> associated with it. ÂThe driver should not be using the platform device
> as an argument for clk_get() in the first place.

I see, I can clearly understand.
Thanks for your kindly reply. :)

Claude
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

Add to Google Powered by Linux