Re: [RFC 0/2] ASoC: core: Option to reorder widget power sequence

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Thu, Dec 02, 2010 at 02:03:08PM +0200, Peter Ujfalusi wrote:

> The first patch implements a new flag for the core to reorder the sequence to:
> 1. User enable the bypass
> 2. The bit enabling the bypass got changed.
> 3. DAPM power up sequence takes place
> 3.1 codec DAPM widgets got powered on, codec is enabled
> 3.2 External speaker enabled

Is this OK on power down?  On power down we'll adjust the input path to
the widget then power down the output path so noise introduced by
switching away from the current source will get amplified.  Keeping the
current sequence for power down seems more consistent with what you're
trying to do.

Looking at the mailing list archive the issues previously were partly
things being obscured by this being in terms of the then very
non-standard TWL4030 code and also this:

| I think there's something useful we can do with DAPM here (independantly
| of anything in TWL4030), probably involving splitting up the routing
| change walk to run power down first and then power up but the current
| patch feels like it's going to cause at least as many problems as it
| solves.

We've now got the split power down/power up sequences - ideally what
we'd be able to do here is get the route update to happen in between the
power down and power up sequences.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


[ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

Add to Google Powered by Linux