[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Google
  Web www.spinics.net

Re: [ANNOUNCE] crash gcore command, version 1.1 available




----- Original Message -----
> Hi HATAYAMA,
> 
> > -----Original Message-----
> > From: HATAYAMA Daisuke [mailto:d.hatayama@xxxxxxxxxxxxxx]
> > Sent: Friday, March 23, 2012 8:38 AM
> > To: crash-utility@xxxxxxxxxx; Lei Wen
> > Subject: Re:  [ANNOUNCE] crash gcore command,
> > version 1.1
> > available
> > 
> > From: Dave Anderson <anderson@xxxxxxxxxx>
> > Subject: Re:  [ANNOUNCE] crash gcore command,
> > version 1.1
> > available
> > Date: Thu, 22 Mar 2012 11:23:36 -0400 (EDT)
> > 
> > > Can you please format the crash-gcore-command-1.1.tar.gz file in
> > > the same manner as crash-gcore-command-1.0.tar.gz?  Here is the
> > > current version:
> > 
> > Thanks for pointing out that, Dave. I attached new one.
> > 
> > And for Lei, I made bigger fault that I missed arm source
> > file... Could you confirm that the new one can work on arm
> > environment?
> 
> Yes, this version works for me.
> 
> However, I think there is a point may need to be enhanced:
> diff --git a/extensions/libgcore/gcore_coredump.c
> b/extensions/libgcore/gcore_coredump.c
> index e2d9941..fec8ffc 100644
> --- a/extensions/libgcore/gcore_coredump.c
> +++ b/extensions/libgcore/gcore_coredump.c
> @@ -200,7 +200,8 @@ void gcore_coredump(void)
>                                         "readmem vma list",
>                                         gcore_verbose_error_handle());
>                         } else {
> -                               pagefaultf("page fault at %lx\n", addr);
> +                               if (paddr == PADDR_NOT_AVAILABLE)
> +                                       pagefaultf("page fault at %lx\n", addr);
>                                 BZERO(buffer, PAGE_SIZE);
>                         }
> 
> Without this, I would see many " page fault at XXX" for the lazy
> mapping as we talked in the previous thread:
> http://www.redhat.com/archives/crash-utility/2012-February/msg00112.html

Given Daisuke's reply in http://www.redhat.com/archives/crash-utility/2012-February/msg00113.html:

  I overlooked lazy allocation case in my explanation... In this sense,
  the warning message might be unkind to users. Still, there's a way of
  checking each page's status by a variety of crash sub-commands.

I was under the impression that Daisuke would prefer to keep the messages
in place in order to give the user notification that those pages are not
accessible.  But I may have misunderstood his intentions.

In any case, since the new version functions correctly, I have posted
the version 1.1 on the extensions page.  

Thanks,
  Dave




--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility


[Home]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Red Hat 9 Bible]     [Fedora Bible]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]

Add to Google

Powered by Linux