Re: [PATCH 13/43] userns: Add kuid_t and kgid_t and associated infrastructure in uidgid.h

[Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>]

Eric W. Biederman wrote:
> Sorry for the late reply.

No problem.

> > unless "!uid_eq(current_uid(), GLOBAL_ROOT_UID)" is identical with
> > "from_kuid(&init_user_ns, current_uid()) != 0".
> 
> Yes the expressions are identical in meaning.
> 
> "!uid_eq(current_uid(), GLOBAL_ROOT_UID)" is both cheaper and more type
> safe so it is to be prefered.

I see.

> The conversions out of kuid and kgid values really only should happen on
> the edge of userspace.

I see.

Other than above, the patch looks OK and userns-always-map-user-v41 passes
my testcases. You can add

  Acked-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>

to commit 30fe03cf "userns: Convert tomoyo to use kuid and kgid where
appropriate".

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html