Re: [PATCH] Smack: allow for significantly longer Smack labels v2

[Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>]

Casey Schaufler wrote:
> +void smk_netlbl_mls(int level, char *catset, struct netlbl_lsm_secattr *sap,
> +			int len)
(...snipped...)
> +	for (cat = 1, cp = catset, byte = 0; byte < len; cp++, byte++)
> +		for (m = 0x80; m != 0; m >>= 1, cat++) {
> +			if ((m & *cp) == 0)
> +				continue;
> +			rc = netlbl_secattr_catmap_setbit(sap->attr.mls.cat,
> +							  cat, GFP_ATOMIC);

Ignoring netlbl_secattr_catmap_setbit() failure? It seems to me that it is not
impossible to handle netlbl_secattr_catmap_setbit() failures in the callers.

> +		}
>  }
>  
>  /**



> +static void smk_preset_netlabel(struct smack_known *skp)
Can mark as __init function?
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html