Re: [RFC 4/4] {RFC} kmod.c: Add new call_usermodehelper_timeout() API
- Subject: Re: [RFC 4/4] {RFC} kmod.c: Add new call_usermodehelper_timeout() API
- From: Oleg Nesterov <oleg@xxxxxxxxxx>
- Date: Thu, 22 Mar 2012 15:42:46 +0100
- Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>, "Rafael J. Wysocki" <rjw@xxxxxxx>, keyrings@xxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, NFS list <linux-nfs@xxxxxxxxxxxxxxx>, Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>, "Bhamare, Sachin" <sbhamare@xxxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, Eric Paris <eparis@xxxxxxxxxx>, "Srivatsa S. Bhat" <srivatsa.bhat@xxxxxxxxxxxxxxxxxx>, Kay Sievers <kay.sievers@xxxxxxxx>, James Morris <jmorris@xxxxxxxxx>, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>, David Rientjes <rientjes@xxxxxxxxxx>
- In-reply-to: <20120322142758.GA12370@redhat.com>
- List-id: <linux-security-module.vger.kernel.org>
- User-agent: Mutt/1.5.18 (2008-05-17)
BTW,
On 03/22, Oleg Nesterov wrote:
>
> In any case. I do not know why do we need timeout, but this is
> orthogonal to KILLABLE. Please redo your patches on top of -mm
> tree? Please note that in this case the change becomes trivial.
I have found 1-3 on marc.info, they look fine.
But 2/4 is not exactly correct, it forgets to do argv_free() if
call_usermodehelper_fns() returns -ENOMEM. And I guess you forgot
to remove the unused "struct subprocess_info *info".
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Fedora Maintainers]
[Fedora Desktop]
[Fedora SELinux]
[Yosemite News]
[Yosemite Photos]
[KDE Users]
[Fedora Tools]