Re: [PATCH] Remove illegal values in nwfilter test XML/firewall files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/27/2014 05:44 AM, Daniel P. Berrange wrote:

You might want to 'git config format.subjectprefix "tck PATCH"' to make
it obvious when you are patching libvirt-tck.

> A number of the nwfilter XML files have attribute values
> which are out of range. Previously the libvirt nwfilter
> XML parser would silently ignore illegal values, causing
> them to default to 0. This resulted in creating incorrect
> iptables rules, which the TCK suite then validated as
> correct. Current libvirt returns a hard error for illegal
> XML values. To address this we either change the attribute
> values to be valid, or delete the bogus rules entirely if
> they are duplicates of other existing valid rules.
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  scripts/nwfilter/nwfilterxml2fwallout/arp-test.fwall      | 1 -

ACK.  Are you also planning on pushing Mike's patches that you have acked?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]